-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry failed tasks via admin #1549
Conversation
b3d2312
to
ec4c9d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only nit was the weight hint but that can be in a follow up. Benchmarking should probably assume a worse case though (conservatively large number of failed batches)
3747f1f
to
bdc131c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. we just need to avoid vecs especially if a storage map can be used...
15e6fd8
to
3350484
Compare
3350484
to
b269651
Compare
Description
restart_batch
Fixes # (issue)
closes: #1394
Type of change
Please delete options that are not relevant.
Test Configuration:
Code review prechecks: